Colin Watson has proposed merging ~cjwatson/launchpad:fix-storm-base into
launchpad:master.
Commit message:
Fix source package recipe webservice query count tests
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/436768
Moving `SourcePackageRecipe*` to `StormBase` had the effect of flushing cached
properties on instances of those classes when the Storm store is invalidated.
This is a good thing, but it resulted in a couple of extra queries in some
query count tests; adjust the expected counts.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:fix-storm-base into launchpad:master.
diff --git a/lib/lp/code/model/tests/test_sourcepackagerecipe.py b/lib/lp/code/model/tests/test_sourcepackagerecipe.py
index 1227ece..6f4d753 100644
--- a/lib/lp/code/model/tests/test_sourcepackagerecipe.py
+++ b/lib/lp/code/model/tests/test_sourcepackagerecipe.py
@@ -1615,7 +1615,7 @@ class TestWebserviceMixin:
store.invalidate()
with StormStatementRecorder() as recorder:
webservice.get(url)
- self.assertThat(recorder, HasQueryCount(Equals(23)))
+ self.assertThat(recorder, HasQueryCount(Equals(25)))
class TestWebserviceBzr(TestWebserviceMixin, BzrMixin, TestCaseWithFactory):
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
