Colin Watson has proposed merging ~cjwatson/launchpad:simplify-tour-css into launchpad:master.
Commit message: Remove User-Agent detection from tour Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/438245 I doubt anyone is really still using Firefox 2 or 3 with Launchpad, and the User-Agent sniffing in the tour wasn't doing anything else useful. -- Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:simplify-tour-css into launchpad:master.
diff --git a/.eslintignore b/.eslintignore index 547c573..e3f66a9 100644 --- a/.eslintignore +++ b/.eslintignore @@ -3,6 +3,3 @@ lib/lp/app/javascript/ellipsis.js lib/lp/app/javascript/gallery-accordion/gallery-accordion.js lib/lp/app/javascript/mustache.js lib/lp/app/javascript/sorttable/sorttable.js - -# Minified third-party files. -lib/lp/app/tour/selector.js diff --git a/lib/lp/app/tour/api b/lib/lp/app/tour/api index 37e2764..fbcf04f 100644 --- a/lib/lp/app/tour/api +++ b/lib/lp/app/tour/api @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/branch-hosting-tracking b/lib/lp/app/tour/branch-hosting-tracking index b527c6c..4c96458 100644 --- a/lib/lp/app/tour/branch-hosting-tracking +++ b/lib/lp/app/tour/branch-hosting-tracking @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/bugs b/lib/lp/app/tour/bugs index f122f4f..721d914 100644 --- a/lib/lp/app/tour/bugs +++ b/lib/lp/app/tour/bugs @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/community b/lib/lp/app/tour/community index 3d36549..8ab7c15 100644 --- a/lib/lp/app/tour/community +++ b/lib/lp/app/tour/community @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/community-support b/lib/lp/app/tour/community-support index c0e5551..3214d5e 100644 --- a/lib/lp/app/tour/community-support +++ b/lib/lp/app/tour/community-support @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/feature-tracking b/lib/lp/app/tour/feature-tracking index a35ddee..b158f47 100644 --- a/lib/lp/app/tour/feature-tracking +++ b/lib/lp/app/tour/feature-tracking @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/index b/lib/lp/app/tour/index index 1398755..793348e 100644 --- a/lib/lp/app/tour/index +++ b/lib/lp/app/tour/index @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/join-launchpad b/lib/lp/app/tour/join-launchpad index 146bf32..c2ecae9 100644 --- a/lib/lp/app/tour/join-launchpad +++ b/lib/lp/app/tour/join-launchpad @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> diff --git a/lib/lp/app/tour/launchpad-tour.css b/lib/lp/app/tour/launchpad-tour.css index 55986f9..bb49e2c 100644 --- a/lib/lp/app/tour/launchpad-tour.css +++ b/lib/lp/app/tour/launchpad-tour.css @@ -66,10 +66,6 @@ height:21px; margin-left:1px; } -.linux.ff2 #navigation-drop-down li a, .linux.ff3 #navigation-drop-down li a { -height:26px; -} - #navigation-drop-down li.current a { background:url(images/btn-dropdown-current.png) no-repeat; } diff --git a/lib/lp/app/tour/ppa b/lib/lp/app/tour/ppa index 99c4b6d..d2a9f50 100644 --- a/lib/lp/app/tour/ppa +++ b/lib/lp/app/tour/ppa @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/release-management b/lib/lp/app/tour/release-management index 5168fc6..a6f04be 100644 --- a/lib/lp/app/tour/release-management +++ b/lib/lp/app/tour/release-management @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container"> diff --git a/lib/lp/app/tour/selector.js b/lib/lp/app/tour/selector.js deleted file mode 100644 index 0668aa7..0000000 --- a/lib/lp/app/tour/selector.js +++ /dev/null @@ -1,8 +0,0 @@ -/* -CSS Browser Selector v0.4.0 (Nov 02, 2010) -Rafael Lima (http://rafael.adm.br) -http://rafael.adm.br/css_browser_selector -License: http://creativecommons.org/licenses/by/2.5/ -Contributors: http://rafael.adm.br/css_browser_selector#contributors -*/ -function css_browser_selector(u){var ua=u.toLowerCase(),is=function(t){return ua.indexOf(t)>-1},g='gecko',w='webkit',s='safari',o='opera',m='mobile',h=document.documentElement,b=[(!(/opera|webtv/i.test(ua))&&/msie\s(\d)/.test(ua))?('ie ie'+RegExp.$1):is('firefox/2')?g+' ff2':is('firefox/3.5')?g+' ff3 ff3_5':is('firefox/3.6')?g+' ff3 ff3_6':is('firefox/3')?g+' ff3':is('gecko/')?g:is('opera')?o+(/version\/(\d+)/.test(ua)?' '+o+RegExp.$1:(/opera(\s|\/)(\d+)/.test(ua)?' '+o+RegExp.$2:'')):is('konqueror')?'konqueror':is('blackberry')?m+' blackberry':is('android')?m+' android':is('chrome')?w+' chrome':is('iron')?w+' iron':is('applewebkit/')?w+' '+s+(/version\/(\d+)/.test(ua)?' '+s+RegExp.$1:''):is('mozilla/')?g:'',is('j2me')?m+' j2me':is('iphone')?m+' iphone':is('ipod')?m+' ipod':is('ipad')?m+' ipad':is('mac')?'mac':is('darwin')?'mac':is('webtv')?'webtv':is('win')?'win'+(is('windows nt 6.0')?' vista':''):is('freebsd')?'freebsd':(is('x11')||is('linux'))?'linux':'','js']; c = b.join(' '); h.className += ' '+c; return c;}; css_browser_selector(navigator.userAgent); diff --git a/lib/lp/app/tour/translation b/lib/lp/app/tour/translation index 78d6bf7..d7f9c88 100644 --- a/lib/lp/app/tour/translation +++ b/lib/lp/app/tour/translation @@ -10,7 +10,6 @@ @import "launchpad-tour.css"; </style> <script type="text/javascript" src="launchpad-tour.js"></script> - <script type="text/javascript" src="selector.js"></script> </head> <body> <div id="container">
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp