Simone has proposed merging ~pelpsi/launchpad:TestOpenIDApplication-does-not-fully-implement-ITestOpenIDApplication into launchpad:master.
Commit message: TestOpenIDApplication does not fully implement ITestOpenIDApplication Added test case to check the correct implementation of ITestOpenIDApplication and fixed TestOpenIDApplication class providing the attribute "title". LP: #837229 Requested reviews: Launchpad code reviewers (launchpad-reviewers) Related bugs: Bug #837229 in Launchpad itself: "TestOpenIDApplication does not fully implement ITestOpenIDApplication" https://bugs.launchpad.net/launchpad/+bug/837229 For more details, see: https://code.launchpad.net/~pelpsi/launchpad/+git/launchpad/+merge/439260 -- Your team Launchpad code reviewers is requested to review the proposed merge of ~pelpsi/launchpad:TestOpenIDApplication-does-not-fully-implement-ITestOpenIDApplication into launchpad:master.
diff --git a/lib/lp/systemhomes.py b/lib/lp/systemhomes.py index 12e0358..fc161ff 100644 --- a/lib/lp/systemhomes.py +++ b/lib/lp/systemhomes.py @@ -357,4 +357,5 @@ class WebServiceApplication(ServiceRootResource): @implementer(ITestOpenIDApplication) class TestOpenIDApplication: - pass + + title = "TestOpenIDApplication" diff --git a/lib/lp/testopenid/tests/__init__.py b/lib/lp/testopenid/tests/__init__.py new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/lib/lp/testopenid/tests/__init__.py diff --git a/lib/lp/testopenid/tests/test_interfaces.py b/lib/lp/testopenid/tests/test_interfaces.py new file mode 100644 index 0000000..33aa59d --- /dev/null +++ b/lib/lp/testopenid/tests/test_interfaces.py @@ -0,0 +1,19 @@ +# Copyright 2010-2018 Canonical Ltd. This software is licensed under the GNU +# Affero General Public License version 3 (see the file LICENSE). + +"""Test Interface implementations.""" + +from zope.component import getUtility + +from lp.testing import TestCaseWithFactory, verifyObject +from lp.testing.layers import DatabaseFunctionalLayer +from lp.testopenid.interfaces.server import ITestOpenIDApplication + + +class TestInterfaces(TestCaseWithFactory): + + layer = DatabaseFunctionalLayer + + def test_ITestOpenIDApplication_implementation(self): + test_open_app = getUtility(ITestOpenIDApplication) + self.assertTrue(verifyObject(ITestOpenIDApplication, test_open_app))
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
