Colin Watson has proposed merging ~cjwatson/txpkgupload:charm-fix-part-name
into txpkgupload:master.
Commit message:
charm: Fix final part name
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/txpkgupload/+git/txpkgupload/+merge/448505
The example in
https://juju.is/docs/sdk/charmcraft-yaml#heading--the-reactive-plugin calls the
final (and in that case only) part "charm". I'd thought that was just an
example. However, as of
https://github.com/canonical/charmcraft/commit/35adadf42c625c5ee5ed6d611c9bdec10413ae59
in charmcraft 2.4.0, calling the final part anything else causes charms to be
misbuilt; they end up containing unmodified copies of the top-level
`actions.yaml`, `config.yaml`, and `metadata.yaml` files rather than merging
the information provided by each layer.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/txpkgupload:charm-fix-part-name into txpkgupload:master.
diff --git a/charm/txpkgupload/charmcraft.yaml b/charm/txpkgupload/charmcraft.yaml
index 3f78635..98f3499 100644
--- a/charm/txpkgupload/charmcraft.yaml
+++ b/charm/txpkgupload/charmcraft.yaml
@@ -45,7 +45,7 @@ parts:
- layers
prime:
- "-layers"
- txpkgupload:
+ charm:
after:
- charm-wheels
- launchpad-layers
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
