Thanks! I made 2 separate commits. I hope this helps! > It seems this commit does a couple of things, which is even indicated by the > commit title containing a "and". > > Later on, when looking at commits, it makes it harder to reason about changes. > > We should try to have separate commits for separate things. > > This also makes reviewing easier. -- https://code.launchpad.net/~enriqueesanchz/launchpad/+git/launchpad/+merge/483925 Your team Launchpad code reviewers is requested to review the proposed merge of ~enriqueesanchz/launchpad:cve-cvss-fix into launchpad:master.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp