İlker Emre Koç has proposed merging
~ilkeremrekoc/launchpad:maven-cargo-metadata-comment into launchpad:master.
Commit message:
Comment out the _publish_properties method calls
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~ilkeremrekoc/launchpad/+git/launchpad/+merge/486834
Currently, calls to artifactory using _publish_properties return 403
errors. Thus, to deploy the rest of the code safely, we will comment
the calls to it until we investigate and fix it.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~ilkeremrekoc/launchpad:maven-cargo-metadata-comment into launchpad:master.
diff --git a/lib/lp/crafts/model/craftrecipebuildjob.py b/lib/lp/crafts/model/craftrecipebuildjob.py
index 58aa740..0baf610 100644
--- a/lib/lp/crafts/model/craftrecipebuildjob.py
+++ b/lib/lp/crafts/model/craftrecipebuildjob.py
@@ -378,7 +378,10 @@ class CraftPublishingJob(CraftRecipeBuildJobDerived):
if result.returncode != 0:
raise Exception(f"Failed to publish crate: {result.stderr}")
- self._publish_properties(cargo_publish_url, artifact_name)
+ # XXX ilkeremrekoc 2025-06-10:
+ # The publish_properties method returns a 403 error.
+ # Until this is resolved, we will not call it.
+ # self._publish_properties(cargo_publish_url, artifact_name)
def _publish_maven_artifact(
self, work_dir, env_vars, artifact_name, jar_path=None, pom_path=None
@@ -442,7 +445,10 @@ class CraftPublishingJob(CraftRecipeBuildJobDerived):
f"Failed to publish Maven artifact: {result.stderr}"
)
- self._publish_properties(maven_publish_url, artifact_name)
+ # XXX ilkeremrekoc 2025-06-10:
+ # The publish_properties method returns a 403 error.
+ # Until this is resolved, we will not call it.
+ # self._publish_properties(maven_publish_url, artifact_name)
def _get_maven_settings_xml(self, username, password):
"""Generate Maven settings.xml content.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
