comments addressed, thanks for the review
Diff comments:
> diff --git a/lib/lp/charms/model/charmrecipejob.py
> b/lib/lp/charms/model/charmrecipejob.py
> index 56efa07..bf06390 100644
> --- a/lib/lp/charms/model/charmrecipejob.py
> +++ b/lib/lp/charms/model/charmrecipejob.py
> @@ -173,6 +173,15 @@ class CharmRecipeRequestBuildsJob(CharmRecipeJobDerived):
> @classmethod
> def create(cls, recipe, requester, channels=None, architectures=None):
> """See `ICharmRecipeRequestBuildsJobSource`."""
> + # architectures can be a iterable of strings or ProcessorsAdd
> + # commentMore actions in the latter case, we need to convert
> + # them to strings
Badly copied, fixing this comment to say:
# architectures can be an iterable of strings or Processors
# in the latter case, we need to convert them to strings.
Fixing the typo 'an' and in here, craftrecipejob.py and rockrecipejob.py model
scripts, which also had this typo.
> + if architectures and all(
> + not (isinstance(arch, str)) for arch in architectures
> + ):
dropping the brackets here and also in rockrecipejob.py model script
> + architectures = [
> + architecture.name for architecture in architectures
> + ]
> metadata = {
> "requester": requester.id,
> "channels": channels,
--
https://code.launchpad.net/~alvarocs/launchpad/+git/launchpad/+merge/486923
Your team Launchpad code reviewers is requested to review the proposed merge of
~alvarocs/launchpad:request-archs-charms into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
