Diff comments:
> diff --git a/lib/lp/code/model/githosting.py b/lib/lp/code/model/githosting.py
> index cc5f84b..a8b60a2 100644
> --- a/lib/lp/code/model/githosting.py
> +++ b/lib/lp/code/model/githosting.py
> @@ -304,6 +309,13 @@ class GitHostingClient:
> logger.info("Sending request to turnip '%s'" % url)
>
> try:
> + # XXX ines-almeida 2025-06-26 we are currently experiencing some
> + # git slowness which leads to timeouts in the merge request
> + # This should help us have control of the timeout for this
> request.
> + timeout = getFeatureFlag(MERGE_TIMEOUT_FEATURE_FLAG)
What is the default that gets returned here?
> + if timeout and timeout.isdigit():
nit: might be worth it to add a debug log here, in case timeout.isdigit() is
false.
> + with override_timeout(int(timeout)):
> + return self._post(url, json=json_data)
> return self._post(url, json=json_data)
> except requests.RequestException as e:
> if e.response is not None:
--
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/488444
Your team Launchpad code reviewers is requested to review the proposed merge of
~ines-almeida/launchpad:merge-button/fix-timeouts into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
