I think we also need to solve the issue of the api not being exposed in `craft_builds`. I think that part is still necessary to add because that's how creation is done.
Diff comments: > diff --git a/lib/lp/crafts/tests/test_craftrecipe.py > b/lib/lp/crafts/tests/test_craftrecipe.py > index 2dd2e7c..f84b748 100644 > --- a/lib/lp/crafts/tests/test_craftrecipe.py > +++ b/lib/lp/crafts/tests/test_craftrecipe.py > @@ -1028,6 +1024,20 @@ class TestCraftRecipeSet(TestCaseWithFactory): > field_value, > ) > > + def test_use_fetch_service(self): > + [ref] = self.factory.makeGitRefs() > + craft = self.factory.makeCraftRecipe( > + git_ref=ref, use_fetch_service=False > + ) > + self.assertEqual(FetchServicePolicy.STRICT, > craft.fetch_service_policy) can you assert that fetch service is indeed false here? > + with person_logged_in(craft.owner): > + craft.use_fetch_service = True > + craft.fetch_service_policy = FetchServicePolicy.PERMISSIVE > + self.assertEqual(True, craft.use_fetch_service) > + self.assertEqual( > + FetchServicePolicy.PERMISSIVE, craft.fetch_service_policy > + ) > + > > class TestCraftRecipeDeleteWithBuilds(TestCaseWithFactory): > -- https://code.launchpad.net/~vaishnavi-asawale/launchpad/+git/launchpad/+merge/491037 Your team Launchpad code reviewers is requested to review the proposed merge of ~vaishnavi-asawale/launchpad:fetch_service_sourcecraft into launchpad:master. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
