Diff comments:
> diff --git a/lib/lp/app/javascript/ui/banner.js
> b/lib/lp/app/javascript/ui/banner.js
> index c5e5c9c..e4c65d8 100644
> --- a/lib/lp/app/javascript/ui/banner.js
> +++ b/lib/lp/app/javascript/ui/banner.js
> @@ -316,6 +317,47 @@ YUI.add('lp.ui.banner', function (Y) {
> }
> });
>
> +
> + /**
> + * Bazaar Banner widget
> + *
> + * This is the Private feature banner which is pretty basic.
> + *
> + * Note that this doesn't automatically follow the information type code.
> + * Nor does it listen to the choice widgets and try to update. It's
> purely
> + * meant to function as told to do so. Most of the work around making
> sure
> + * the banner shows and works properly is in the View code in global.js.
> + *
> + * @class PrivateBanner
> + * @extends Banner
> + *
> + */
> + ns.BazaarBanner = Y.Base.create('banner', ns.Banner, [], {
> +
> + }, {
> + ATTRS: {
> + badge_text: {
> + value: ''
> + },
> +
> + content: {
> + value: 'Launchpad will phase out support for Bazaar soon.
> Active projects should be migrated to Git.'
I think the message should be stricter. Something on the lines of "Launchpad
will shut down the Bazaar codehosting service."
> + },
> +
> + /**
> + * Manually force the banner type so users don't need to set it.
> + * This is a private banner class.
> + *
> + * @attribute banner_type
> + * @default PRIVATE
> + * @type {String}
> + */
> + banner_type: {
> + value: ns.BAZAAR
> + }
> + }
> + });
> +
> }, '0.1', {
> requires: ['base', 'node', 'anim', 'widget', 'lp.mustache', 'yui-log']
> });
--
https://code.launchpad.net/~finnrg/launchpad/+git/launchpad/+merge/493355
Your team Launchpad code reviewers is requested to review the proposed merge of
~finnrg/launchpad:feat/bazaar-banner into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
