On Wed, 22 Apr 2009 01:54:57 +1100 Alexander Klenin <kle...@gmail.com> wrote:
> On Tue, Apr 21, 2009 at 19:45, Mattias Gaertner > <nc-gaert...@netcologne.de> wrote: > >> 4) I still think ' ' (space) should be added to the list of ignored > >> constants -- for those who prefer to turn single-char constant > >> detection on. > > > > Why ' ' and not #10 or #13 or #0? > > It is by far the most common. I doubt that: lazarus sources: #10: 911 #13: 1425 #0: 1125 ' ': 1740 Without debug calls there are only about 1000 ' '. fpc sources: #10: 1213 #13: 5766 #0: 2384 ' ': 1846 Without debug calls there are only about 1500 ' '. > Also, unnamed #10 and #13 might indicate platform-dependent line > endings usage. And ' ' might indicate i18n problems. > >> 5) 'Show Code observer' group box should better be named 'Show > >> observations' > >> > >> 6) Some kind of sorting is necessary for the observations in the > >> box. Perhaps at least alphabetical? > > > > A patch is welcome. > > http://bugs.freepascal.org/view.php?id=13551 > > BTW, can you please also review > http://bugs.freepascal.org/view.php?id=13501 ? It followed from our > previous discussion. I will take a look. Mattias _______________________________________________ Lazarus mailing list Lazarus@lazarus.freepascal.org http://www.lazarus.freepascal.org/mailman/listinfo/lazarus
