On 31/03/2011 00:31, Zaher Dirkey wrote:
On Thu, Mar 31, 2011 at 12:21 AM, Martin <[email protected] <mailto:[email protected]>> wrote:

    On 30/03/2011 22:47, Zaher Dirkey wrote:

        I found many of {$IFDEF SYN_LAZARUS} in SynEdit, my ask is
        SynEdit used outside Lazarus (like Delphi for example)?

    they are a relict from another time....

    They were once meant to mark all places were SynEdit in Lazarus
    changed from the original synedit.
    But they do no longer work.

    Only the SYN_LAZARUS version compiles, without it it will not even
    compile.
    I started remove them a year or 2 back, but never finished....

    Martin


Can i remove it, and send the patch?


yes, but...
do it in small bits, because I still need/want to review. And I am a bit low on time...

Also, if you do any other cleanup: do it in separate patches please

Obviously the functionality need no review, just checking for typos, or flipping the if and else part, etc (big operations like this, almost always introduce an error somewhere)
otherwise I had them all removed already

Also I want to check any bigger block (several lines / if still existing), if the code still serves as inspirations. But small bits, are fine.

If you want to clean up a particular bit, in order to start reading into the code, thats cool...

---
Actually, just thinking about, could be easiest to run a perl script over it.....

Martin

--
_______________________________________________
Lazarus mailing list
[email protected]
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply via email to