On Fri, May 18, 2012 at 6:55 PM, Ludo Brands <[email protected]> wrote:
> A month ago I added to mantis a patch that adds a metadata browser to the > SQL editor window of TSQLQuery. It facilitates creating queries > considerably > without the need of an external database viewer to get the exact table and > column names. Can anybody of you please take a look at it. > > http://bugs.freepascal.org/view.php?id=21815 > I applied it, thanks. I did only minimal testing but it looks good. Looking at the comments, other people have tested it already, and now more people will test it because it is in trunk repository. It is bad if valid patches are ignored just because developers are busy. I didn't apply it earlier because I am not an expert of the DB stuff. I expected someone else will do it. Ignoring a patch for a long time feels like negative feedback. And if you must modify your patch to make it match the changes in trunk source, it feels even more negative. I remember it well from my early "Configure Build Lazarus" patch. There are many contributors at least as clever as me, yet I have a commit access but they don't. To make things smoother their patches should be applied rather quickly, as they are typically equally good with commits from the "real" developers. I remember last summer I applied many patches from Anton and Cobines and others. Other developers had maybe a summer holiday from Lazarus and they didn't look at patches much, but some other people used they free time for creating patches. I will do the same thing this summer if needed. BTW, a long time contributor Bart just got a commit access for LCL. Juha
-- _______________________________________________ Lazarus mailing list [email protected] http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
