On 02/06/2012 08:23, Ludo Brands wrote:
1) this a 2 individual things.
keeping a scrolling history in the evaluate window can be
done for all
evaluates. May even be useful. Could have a checkbok in that window.
So that part is to be skipped. But a better version is welcome.
What would a better version look like, other than the checkbox and perhaps a
clear history button? Ctrl-A del works perfectly btw. A better visual
differentiation between expression and result?
Well It would have a checkbox, to decide if history is kept, or if
result replaces all.
Maybe insert
--------------
between results
Btw, what do you think about insert on top and scroll the down?
2)
Any reason to limit to wdDefault ?
Since you always set ddsValid you could have it in the main
method body
(where the "!" is handled ( a relict, that will go ....))
1) I didn't know the debugger code before starting this little patch.
wdDefault is used in both evaluate and watch. And all the functions and
variables needed are in scope of the function since they are used in the
other "case" blocks. I noticed the main body and the handling of "!" but
took the road of least resistance and put the code where all was available,
guaranteed, without further investigation.
2) It is cleaner to have same level of functionality in the same place. Even
if not limited to wdDefault I would have put the 'if' before the 'case'.
3) In hind sight, for the watch, I prefer getting an error message when
selecting display options like mem dump, character, decimal on a cli command
than ignoring them. A new watch is created with wdDefault and a user selects
another display format if he wants another format. With cli commands he
won't get another format and the error message will somehow ack that.
Then the error message needs implementing (well would need, if the code
was added for everyone). And we would already have maintenance....
One of the reasons I do not like the location in, that the entire
subroutine is subject to finding parent frames in nested subroutines.
Only your code will never.
--
_______________________________________________
Lazarus mailing list
[email protected]
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
