On 13-09-2014 07:00, Reinier Olislagers wrote:
1. function TChmHelpViewer.ShowNode(Node: THelpNode; var ErrMsg: string ): TShowHelpResult; in components\chmhelp\packages\idehelp\lazchmhelp.pas has if Pos('file://', Node.URL) = 1 then begin Result := PassTheBuck(Node, ErrMsg); Exit; end;Is ignoring the results of the PassTheBuck (nice name ;) ) call on purpose or should it be changed to Exit(Result)?
Just above Exit the "Result" of the function is already set in Result so there is no need for the parameter in Exit (it's already set).
(Even the ErrMsg is given back via the var-parameter of ShowNode) (You were probably really tired :)) -- _______________________________________________ Lazarus mailing list Lazarus@lists.lazarus.freepascal.org http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus
