On Mon, 12 Sep 2005 19:22:56 +0200
Dex <[EMAIL PROTECTED]> wrote:
> Solves #594, #654, #790, #454
On Tue, 13 Sep 2005 11:55:55 +0200
Vincent Snijders <[EMAIL PROTECTED]> wrote:
> Mattias Gaertner wrote:
> > I got a patch.
> > I can't test it myself, but I wonder, why the fImg.Picture.clear;
> > 'fixes' it.
> >
> > TImageListEditorDlg.OnLVLSelectItem calls
> >
> > fImg.Picture.BitMap:=Bmp;
> > which calls
> > TPicture.SetGraphic
> > which frees the old bitmap and assigns the new. So, the old is gone.
> > So, neither fImg.Picture.clear nor the fImg.Picture.BitMap.Canvas. lines
> > have any effect.
> >
> > Can you test it?
> >
> > We should remove the fImg.Picture.BitMap.Canvas lines.
> >
>
> I can not reliably reproduce a crash. :(
>
> First I used current lazarus, and created an app with a TImageList and try
> to add some images from the the images directory. I got a crash when I
> closed the image list editor.
>
> Then I applied the patch and recompiled lazarus. After that I could use
> the TImageList editor.
>
> Because I was curious what exactly caused the crash, I tried to the old
> lazarus again (and one of yesterday). But then I couldn't get it to
> crash, so the imagelist editor seems to work there too. So I can't tell
> whether the patch fixes things or not.
I removed the canvas lines.
Because 'Clear' does nothing and solves the bug, then I guess, we have a mem
corruption somewhere.
Mattias
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
