Hi,
Am Sonntag, den 06.11.2005, 10:39 +0100 schrieb dannym:
> hi,
>
> Am Sonntag, den 06.11.2005, 10:31 +0100 schrieb Mattias Gaertner:
> > On Sun, 06 Nov 2005 08:14:42 +0100
> > dannym <[EMAIL PROTECTED]> wrote:
> >
> > > Hi,
> > >
> > > attached is an initial patch to make the gtk 2.6 filechooser work for
> > > lazarus (lcl).
> > >
> > > Still needs some gtk version detection magic I guess (if we want to
> > > support gtk2 < 2.6, that is)
> > >
> > > Note that gtk 2.8 contains:
> > > void gtk_file_chooser_set_do_overwrite_confirmation
> > > (GtkFileChooser *chooser,
> > > gboolean
> > > do_overwrite_confirmation);
> > > However, that's probably _too_ new ;)
> >
> > Thanks for the patch. There are a few issues:
> >
> > - 2.4 is still used. Can you enclose the changes in {$IFDEF HasGTK2_6}?
> > - You made some methods virtual - good. But you do not use the inherited
> > code and instead copy big parts. Either split the gtk1 methods, so you only
> > need to override the different parts or move the method bodies into include
> > files.
>
> Okay...
>
> is ...
>
> {$IFDEF HasGTK_2_6}
> <long new code>
> {$ELSE}
> inherited;
> {$ENDIF}
>
> ... ok ?
>
> and yes, for the ExtractFilterList part, it would be best if that would
> be moved somewhere more general (into a .inc file or so ?) and
> documented that the list items are PFileSelFilterEntry.
I moved ExtractFilterList to it's own .inc file now, where to put the
{$INCLUDE } ?
I tried the top of gtkobject.inc, but seems like a bad place...
Where is the glue located ? :)
grep -R -i "\$INCLUDE" * in interfaces/ doesn't find much, only two
occurences in gtk2/gtk2int.pas ...
>
> Can you do that ? You know best which parts should be shared, and which
> shouldn't... (and where to create the .inc file / what to name it / how
> and where to include it)
>
> also, is FilterList disposed of somewhen ? I don't see where it was
> disposed of in the gtk1 code... (the one in the LCLFilterList userdata).
> I'm not sure I even need to keep it around for gtk2, but I thought
> better be consistent so I put it into the userdata nevertheless.
hmm
cheers,
Danny
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
