> > So we had to fix this in TDataset. 
> > I've done it, it's committed, if someone could please give it a test, 
> > I would be grateful.

What if someone calls TDataset.GetfieldData(aField,aBuffer); ? Then it
will return the wrong - TTimeStamp value. (iirc TField uses GetFieldData
without NativeFormat-parameter, so that one will fail)

As I wrote it, the default for NativeFormat is False, since you never
need the nativeformat. That's only for low-level-data operations. But
now you have:

If NativeFormat then Result:=GetFieldData(Field, Buffer)

That's completely counter-intuitive, since GetFieldData without
NativeFormat-parameter assumes that NativeFormat is False.

Further the max string-size is 4096 (iirc, it's defined in db.pp) The
TempBufSize of 1024 is not enough for that. And i know of people who
increased that value, or who work with larger buffers...

Does Delphi has a DataConvert function defined as you did define it?

(I saw you changes some TDataset descendents to work with this change,
the change for sqldb however should have been done in TBufDataset, since
this component already relies on the TDateTime.)

Joost.

_________________________________________________________________
     To unsubscribe: mail [EMAIL PROTECTED] with
                "unsubscribe" as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives

Reply via email to