Mattias Gaertner wrote:
On Thu, 26 Jan 2006 22:02:19 +0100
Mattias Gaertner <[EMAIL PROTECTED]> wrote:
On Wed, 25 Jan 2006 10:01:03 +0100
darekm <[EMAIL PROTECTED]> wrote:
I forget patch
Marc Santhoff wrote:
Am Dienstag, den 24.01.2006, 18:41 +0100 schrieb darekm:
Darek
PS. how simple test patch syntactic
patch -C < <yourmodifictions.diff>
From the man page of patch(1):
-C, --check
see what would happen, but don't do it.
I know, this is impossible, but my patch don;t have this options (I use
Gentoo)
Thanks. Applied.
Some notes:
1. Don't use writeln in the LCL code. Instead use debugln. Debugging code
is easily forgotten and can then crash the application.
2. Don't split functions and their comment. For example:
Sorry (I know, but I forget)
{------------------------------------------------------------------------
-- ----
function GdkAtomToStr(const Atom: TGdkAtom): string;
Returns the associated string
-------------------------------------------------------------------------
-- ---}
function GdkAtomToStr(const Atom: TGdkAtom): string;
var
p: Pgchar;
...
You added three empty lines between the comment and the function. Why?
I disabled it for SystemColors. See TGtkWidgetSet.SetWidgetColor.
That is not good, for me better do it in function ColorToRGB(Color:
TColor): TColor (if it's not enought)
If they return clNone then setWidgetColor is not call
Darek
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
