On Tue, 09 May 2006 00:44:14 +0200
Giuliano Colla <[EMAIL PROTECTED]> wrote:
> Felipe Monteiro de Carvalho ha scritto:
>
> > Ok, now it works thanks =)
> >
> > Giuliano, you implemented TQtWSWinControl.SetText and GetText. I find
> > it cleaner if we don't implement this properties on TQtWSWinControl,
> > but instead implement them on each of the derivated controls.
> >
> I did simply follow what had been made in other interfaces: I needed a
> TEdit to enter and display lines of TMemo, so I did the minimum in order
> to have it working. But I agree with you. This was just quick and dirty.
> I'm planning to tackle TEdit, now, as I begun working on it, and I'll
> try to do something better.
>
> > Also set and get text for the spinedit were incorrect and caused
> > crashes. I will soon send a patch fixing this.
> >
> > One question: SetText for TMemo is calling QTextEdit_append and this
> > will add a new line to the text of TMemo. Is this correct? Shouldn't
> > TMemo.Text be the full textual contents of the memo?
> >
> Sorry, I don't understand. I find a TQtWSCustomMemo.AppendText in
> qtwsstdctrls.pp which calls only QTextEdit_append (and actually appends
> text), and, in qtmemostrings.inc, a TQtMemoStrings.SetText which calls
> ExternalUpdate with parameters set as to perform a QTExtEdit_clear
> before QTextEdit_append and actually sets the full text. I don't see a
> SetText calling QTextEdit_append only.
>
> > Also, the file qtmemostring.inc could become a .pas file. What do you
> > think? I would also propose another name. We could use a generic unit
> > with helper classes. Somewhere to put all helper classes that don't
> > fit qtprivate.pas. Maybe qtobjects.pas?
> >
> You're right, but, on the other hand keeping the same file structure for
> different interfaces makes it much easier for subsequent developers to
> navigate across sources. This file scheme is the same as in gtk/gtk2 and
> win32. Let's think over it a bit.
> What other guys (such as Mattias) do think about that?
The include files in gtk/gtk2 interface were added for overriding and to
keep some files smaller.
Please use for secondary units/include files whatever you think is
appropriate.
Mattias
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
