Re: [lazarus] [patch] popmenu.align added

[darekM]

Mattias Gaertner napisał(a): On Wed, 10 May 2006 20:31:24 +0200 darekM <[EMAIL PROTECTED]> wrote: Mattias Gaertner napisa?(a): On Wed, 10 May 2006 17:55:05 +0200 darekM <[EMAIL PROTECTED]> wrote: Mattias Gaertner napisa?(a): On Wed, 10 May 2006 09:16:44 +0200 darekm <[EMAIL PROTECTED]> wrote: Mattias Gaertner wrote: On Tue, 09 May 2006 23:17:13 +0200 darekm <[EMAIL PROTECTED]> wrote: HI as in subject and some const Where is the code that implements the property? what code property Alignment: TPopupAlignment read FAlignment write FAlignment >>> default paLeft; its only declaration Why do we need a property without function? 1.Compatibility with Delphi Delphi uses and sets the property. For example in TMenuItem.AdvancedDrawItem and TPopupMenu.UseRightToLeftAlignment. Why thats not enough to apply this patch. I've port one component that use AdvancedDrawItem, and my patch was first step to build those procedure. But if I must every such thing explain? Nothing personal. We need to make sure, that no useless properties are added to the LCL only to let .dfm load with lesser errors or some Delphi code gives less errors. Why not. Programs are build step by step. Better is add something to avoid some of compiling errors now, and in future make progress on it. If we investigate all LCL (or even VCL) we found some places that seems unnecessary. Of course is very important to avoid slowness and huge memory consumption. I've been resist to add not useless field to tMemoItem, but tPopupMenu is different. Nobody have more than 1000 menus, but tMemoItem are many more. Every added property must be implemented and work on almost all platforms. Are you sure, that every property  work "on almost all platforms". When some of us make property to one platform, others must wait until somebody implement it on second (third...) platform. How to add new property working on all platforms at once. And publish properties when they work. Maybe PUBLIC will enough in my patch. (I don't understand difference between PUBLIC and PUBLISHED. Darek