On 3/26/06, Ere Maijala <[EMAIL PROTECTED]> wrote:
Mattias Gaertner wrote: > On Sun, 26 Mar 2006 13:21:42 +0300 > Ere Maijala <[EMAIL PROTECTED]> wrote: > >> Mattias Gaertner wrote: >>> On Mon, 20 Mar 2006 14:36:11 +0200 >>> "Ere Maijala" <[EMAIL PROTECTED]> wrote: >>> >>>> On 1/4/06, Mattias Gaertner <[EMAIL PROTECTED]> wrote: >>>>> On Mon, 05 Dec 2005 14:22:33 +0200 >>>>> Ere Maijala <[EMAIL PROTECTED]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> it seems to me that the code in promptdialog.inc didn't center the >>>>>> dialog text as it should. How about the attached patch? Looks quite a >>>>>> bit better for me, though I've only tested on Windows. As soon as we >>>>>> get rid of the glyphs in the buttons, the dialogs will be quite ok.. >>>>> You forgot to alter the comments, so I can only guess, what you >>>>> intended. >>>>> >>>>> Maybe you want a space on the right side of the size of the icon on >>> the >> left? >>>>> >>>> Hi, >>>> >>>> I kind of forgot this but now I'm back again with a new patch. What I >>>> really want is the text to be on the middle of the dialog regardless >>>> of the glyph. Previously the text was way too much to the right >>>> because the text offset was only taken into account on the left side >>>> of the text although the text should have been as far from the right >>>> border of the dialog. >>> Thanks. But IMO it looks like a waste of space and I don't know any >>> program, that centers a left aligned text in its messages. Maybe I'm >>> using the wrong applications? >> Do you mean Lazarus shouldn't be centering the text of a MessageDlg at >> all? An example showing how it's wrong now is: >> >> MessageDlg('Short MessageDlg', mtInformation, mbYesNoCancel, 0); >> >> Attached is an example of what it produces. > > Ah. I see. So you mean, if there is space, then the label should be centered > on the dialog. I agree with that. But it seems the patch adds extra space to > the right.Ok, I'll try to come up with a better patch later.
It took me a while to get back to this, but here is yet another try. Now the text is centered if there is space. --Ere
dialog.diff
Description: Binary data
