Christian Ulrich schreef:
Christian Ulrich schreef:
Can somebody please tell me whats wron with this patch ?
Did you really expect an answer within 20 hours?
no but Felipe Monteiro de Carvalho has askd if this is ok as i implemented
at 12. November 2006 on 3:16 GMT+1
nobody has answered so i expect that the implementation this way is ok
(other patches are applied within 4 hours and matthias, you and Marc have
answered more than one time in this time so i expect that everyone has read
the mail and agree.
then i implement this and ...
I can only speak for myself, don't know about Marc, Mattias or Micha.
I read the mail, but found time to formulate an answer and to be honest,
I didn't feel like I had the 'authority' to commit the patch anyway.
Can somebody please tell me, what is wrong with the note 9741 on bug
http://www.freepascal.org/mantis/view.php?id=2066 . I waiting now for
more than 4 days for feedback from the reporter.
iam sorry i dont get mails fr4om mantis on such issues at examples notes on
my bugs and so on. can i switch this on somewhere ?
I think you should be able to set this on
http://www.freepascal.org/mantis/account_prefs_page.php.
If this doesn't work, create a bug report for it on
http://www.freepascal.org/mantis/set_project.php?project_id=4
i have answered please mark it as fixed and i close it.
Thanks. I have set the status to resolved.
I found a little time to look at this patch.
First:
I doubt the general usefulness of having the applicationtype as member
of TApplicationProperties. TApplicationProperties are part of a from,
which is created at its earliest *after* the call to
Application.Initialize. So generally the ApplicationType isn't changed
until known after the call to TWidgetSet.Create *and*
TWidgetSet.AppInit. This limits its usefulness.
why does this limit its usefullness ? when we set it in the projectoptions,
its also
set only on appstart.
Before the call to the Application.Initialize.
I think it would be better to set the ApplicationType in the Project
Options as part of the Application Settings groupbox. The IDE would
add/edit/remove the
Application.ApplicationType := atDesktop;
line just before Application.Initialize in the .lpr file.
yes, maybe what schould i do ? schould i remove it from
TApplicationProperties ?
Secondly the patch contains several fixes at once. It is better to
create separate patch files for it.
Can you implement this? It would be nice to have all modifications
related to this on a single patch.
i only act like felipe has sayed.
Or apply it !?
I cannot do it, I don't apply LCL and wince patches without consent of
other lazarus developers, unless the patch is trivial and undisputed.
for shure, and i will in the future only send patches when i real need the
contents.
That I cannot commit a patch, should not stop you from sending patches.
Felipe can better judge if wince patches are OK. Mattias can better
judge LCL patches than I can.
its simply to problematic to ask 5 developers to get an patch applied. when
i post it here nobody answer so the only way seems to be to write 5 mails to
the core developers ?
It is no problem to ask here to apply a patch. In this case that
question came a bit fast (IMHO).
PLEASE can somebody say what i have to do to get this fix into lazarus
i will cut the patch into one general lcl part and one wince part.
and will remove the change of tapplicationproperties.
IMHO the TApplicationProperties part is questionable, so let's discuss
it a bit more, get input from other developers.
I will apply the TApplication part (because I don't have any problems
with that and Marc looked at it too) and if Felipe says ok, I will the
wince part too.
Vincent
_________________________________________________________________
To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
