Vincent Snijders wrote:
Marc Weustink schreef:
Luis Rodrigues wrote:
Could someone please take a look ate this issue and commit my patch
since I really need that to be working.

http://www.freepascal.org/mantis/view.php?id=9491


Typical borland solution. Personally I think that grouping on group number is better. (maybe we can add that someday) Anyway patch looks ok, however I would group the or statements together. I find mixing or and and statements unreadable.

(A or B or C and D) isn't clear ((A or B or C) and D) is.


((A or B or C) and D) is more clear, but it is different too.

(A or B or (C and D)) is more clear equivalent of the first expression.

A: true
B: false
C: false
D: false

(A or B or C and D): true.
((A or B or C) and D): false.

I think ((A or B or C) and D) is what the bug fix should be, and so this patch is wrong.

I'm not so good at boolan logic, thats why I always add brackets (but I think the evaluation is from left to right).

Anyway I applied a modied patch:
  style in [a,b,c]
instead of
  ((style = a) or (style = b) or (style= c))

Marc :)


_________________________________________________________________
    To unsubscribe: mail [EMAIL PROTECTED] with
               "unsubscribe" as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives

Reply via email to