On 13/11/2007, Sam Liddicott <[EMAIL PROTECTED]> wrote: >> The tiOPF project is normally against using Variants, > this interesting if it is a "blanket" policy, unless it is a blanket policy > against the blanket use of variants :=)
tiOPF does contain variants in code, we are just trying to minimize it's usage and replaced a lot before. In a previous version of tiOPF (when we still supported Delphi 6), the timing unit tests showed exactly how much slower variants were, even compared to other Delphi versions like 5 and 7. > However, removal of the non-variant implementations was certainly overkill, > IMHO Good point. > ...and I thought we were talking about whether or not fpc/lazarus should > retain variants as a feature - if only you had explained... :-) Sorry if my intentions were unclear and misleading the thread. This is the description of the patch included in the email. Not sure if attaching the actual patch would make sense, so left it out. The snippet I quoted before got the point across, I think. -------------------------------------------------------------- The attached patch does the following: o Changed Criteria to use variants instead of strings, so it can cope with more data types (ie floats, dates etc) o Changes Criteria to generate sql with params instead of string o Added TtiQueryParams.SetValueAsVariant to make code cleaner o unit tests for above -------------------------------------------------------------- Regards, - Graeme - _______________________________________________ fpGUI - a cross-platform Free Pascal GUI toolkit http://opensoft.homeip.net/fpgui/ _________________________________________________________________ To unsubscribe: mail [EMAIL PROTECTED] with "unsubscribe" as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
