On Tue, 10 Jun 2003, Mark Rubin wrote: > #ifdef TRIVIAL_SUGGESTION_1 > diff README.1ST~ README.1ST > 11c11 > < configure > --- > > ./configure > #endif
It will be done ... > #ifdef TRIVIAL_SUGGESTION_2 > You've released two versions of your modifications, both > named lcms-1.10c.tar.gz and both at the same FTP URL. Please consider > adding additional versioning info to avoid ambiguity. > #endif What should I call it? I added the 'c' extension to indicate 'configure' but I notice that the header file says that lcms 1.10 is actually 1.10b, so it seems that the 'c' was accidentally a natural progression. :-) > #ifdef TRIVIAL_SUGGESTION_3 > There seems to be extraneous whitespace changes between your files and > the stock 1.10 release. Consider making as few changes as possible > beyond the requirements of configure-ization. > #endif The lcms header files contained extra CRs at the end of many lines. I stripped these extra CRs so they use proper Unix line terminations. Maybe this is the whitespace change you are seeing? I did strip out a bunch of porting logic which was rendered unnecessary, and added a few minor fixes to compile using GCC under Windows (MinGW). Currently the configure script is performing substitutions directly on the two lcms headers. This seems to work fine as long as the lcms headers don't need to #undef anything. If an #undef is needed, then a third header will be needed for configuration since otherwise configure will comment out the #undef lines. > I'm a big fan of configure. I hope Marti sees fit to include your > work (or some modification thereto) in his future releases. I hope so too. Bob ====================================== Bob Friesenhahn [EMAIL PROTECTED] http://www.simplesystems.org/users/bfriesen ------------------------------------------------------- This SF.NET email is sponsored by: eBay Great deals on office technology -- on eBay now! Click here: http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 _______________________________________________ Lcms-user mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/lcms-user
