Hello !

I'm the Fedora lcms package maintainer since August 2007

Here are some patches that I have collected with date and rpm release
when they first appeared; they are meant to be merged in next 1.18 release.

* Tue Oct 28 2008 kwizart < kwizart at gmail.com > - 1.17-6
- Add lcms-fix_s390_lcms_h.patch - Fix #468245
...
* Tue Jun 3 2008 kwizart < kwizart at gmail.com > - 1.17-5
- Fix Array indexing error in ReadCurve - #448066


Bugzilla direct link:
http://bugzilla.redhat.com/show_bug.cgi?id=468245
https://bugzilla.redhat.com/show_bug.cgi?id=448066

For the lcms-1.16-python-lib64.patch:
On multilibs 64bit system (ppc64 and x86_64 for main arches on Fedora)
The python directory for architecture dependant object is :
/usr/lib64/python2.5/site-packages whereas lcms uses
/usr/lib/python2.5/site-packages which is suitable for architecture
independant scripts.
Once the patch is added, lcms will install its python binding in the
accurate directory, even on OSes that do not use lib64 directory on
x86_64/ppc64 hosts.


Nicolas Chauvet (kwizart)



ps:  btw the lcms download page would need some update.
* The current package maintainer can be seen here:
https://admin.fedoraproject.org/pkgdb/packages/name/lcms
I'm the current active maintainer despite not been the primary maintainer.
* viewcvs of lcms:
http://cvs.fedoraproject.org/viewvc/rpms/lcms/
* Suggested updated fedora logo ( see attachment for same size candidate)
https://fedoraproject.org/wiki/Logo
(please request another size to the art team if wanted)





Index: modules/lcms/src/cmsio1.c
===================================================================
RCS file: /cvsroot/mozilla/modules/lcms/src/cmsio1.c,v
retrieving revision 1.2
diff -u -8 -p -r1.2 cmsio1.c
--- modules/lcms/src/cmsio1.c   6 Aug 2007 20:01:21 -0000       1.2
+++ modules/lcms/src/cmsio1.c   3 Jan 2008 11:15:18 -0000
@@ -919,17 +919,17 @@ LPGAMMATABLE ReadCurve(LPLCMSICCPROFILE 
            icUInt32Number Reserved;
            icUInt16Number   Type;
            int i;
            
            if (Icc -> Read(&Type, sizeof(icUInt16Number), 1, Icc) != 1) return 
NULL;
            if (Icc -> Read(&Reserved, sizeof(icUInt16Number), 1, Icc) != 1) 
return NULL;
            
            AdjustEndianess16((LPBYTE) &Type);
-           if (Type > 5) {
+           if (Type > 4) {
 
                 cmsSignalError(LCMS_ERRC_ABORTED, "Unknown parametric curve 
type '%d' found.", Type);
                 return NULL;
            }
         
           ZeroMemory(Params, 10* sizeof(double));
           n = ParamsByType[Type];
 
@@ -1028,17 +1028,17 @@ LPGAMMATABLE ReadCurveReversed(LPLCMSICC
            icUInt16Number   Type;
            int i;
 
 
            if (Icc -> Read(&Type, sizeof(icUInt16Number), 1, Icc) != 1) return 
NULL;
            if (Icc -> Read(&Reserved, sizeof(icUInt16Number), 1, Icc) != 1) 
return NULL;
            
            AdjustEndianess16((LPBYTE) &Type);
-           if (Type > 5) {
+           if (Type > 4) {
 
                 cmsSignalError(LCMS_ERRC_ABORTED, "Unknown parametric curve 
type '%d' found.", Type);
                 return NULL;
            }
         
           ZeroMemory(Params, 10* sizeof(double));
           n = ParamsByType[Type];
 
--- lcms-1.16/configure.ac.python-lib64 2007-02-05 15:00:39.000000000 +0100
+++ lcms-1.16/configure.ac      2007-02-05 15:00:43.000000000 +0100
@@ -94,7 +94,7 @@
   if test -n "$PYTHON"
   then
        LCMS_PYTHON_PREFIX=`$PYTHON -c "import sys; print sys.prefix"`
-       LCMS_PYEXECDIR=`$PYTHON -c "from distutils import sysconfig; print 
sysconfig.get_python_lib()"`
+       LCMS_PYEXECDIR=`$PYTHON -c "from distutils import sysconfig; print 
sysconfig.get_python_lib(1)"`
     LCMS_PYINCLUDE=`$PYTHON -c "from distutils import sysconfig; print 
sysconfig.get_python_inc()"`    
        LCMS_PYLIB=`$PYTHON -c "from distutils import sysconfig; print 
sysconfig.get_python_lib(0,1)"`
        AC_CHECK_FILE([$LCMS_PYINCLUDE/Python.h],PYTHON_OK='yes',PYTHON_OK='no')
--- lcms-1.17/include/lcms.h.s390
+++ lcms-1.17/include/lcms.h
@@ -139,7 +139,8 @@
 #   define USE_BIG_ENDIAN      1
 #endif
 
-#if defined(__sgi__) || defined(__sgi) || defined(__powerpc__) || 
defined(sparc) || defined(__ppc__)
+#if defined(__sgi__) || defined(__sgi) || defined(__powerpc__) || 
defined(sparc) || defined(__ppc__) \
+                     || defined(__s390__) || defined(__s390x__)
 #   define USE_BIG_ENDIAN      1
 #endif
 
@@ -153,7 +154,7 @@
 # endif
 #endif
 
-#if __BIG_ENDIAN__
+#ifdef __BIG_ENDIAN__
 #   define USE_BIG_ENDIAN      1
 #endif
 

<<inline: header-fedora_logo.png>>

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Lcms-user mailing list
Lcms-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lcms-user

Reply via email to