Hi all,
I finally got around to switching vips to lcms2. It was easier than I
expected, and I get a nice performance improvement now I can call
cmsDoTransform() from several threads. Thank you very much for this
new version.
I noticed a couple of tiny things when building lcms-2.0a with gcc's
-Wall on Ubuntu 10.04:
transicc.c: In function ‘GetLine’:
transicc.c:591: warning: implicit declaration of function ‘isatty’
I guess there's a missing <unistd.h> somewhere.
utils/common/vprf.c: In function ‘ChanCountFromPixelType’:
utils/common/vprf.c:318: warning: control reaches end of non-void function
utils/common/vprf.c: In function ‘PixelTypeFromChanCount’:
utils/common/vprf.c:283: warning: control reaches end of non-void function
and several related warnings. The function FatalError() in that file
could be tagged as not returning, with a __attribute__, or you could
add extra return statements I suppose.
linkicc.c: In function ‘main’:
linkicc.c:297: warning: operation on ‘nargs’ may be undefined
Here you have a line:
Profiles[nargs++] =
cmsCreateInkLimitingDeviceLink(cmsGetColorSpace(Profiles[nargs-1]),
InkLimit);
The C standard does not say whether the nargs++ on the LHS of = is
evaluated before or after the nargs on the RHS. I suppose this should
be split to two lines.
jpgicc.c: In function ‘Help’:
jpgicc.c:887: warning: too many arguments for format
I guess a copy-paste error, there's a SW too many.
jpgicc.c: At top level:
jpgicc.c:72: warning: ‘OutOfMem’ defined but not used
The function could probably go.
John
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://p.sf.net/sfu/dev2dev-palm
_______________________________________________
Lcms-user mailing list
Lcms-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lcms-user
