On 30 May 2013 08:56,  <marti.ma...@littlecms.com> wrote:
> Release data for 2.5 is approaching fast, so I've
> put a release candidate in lcms site:

Brilliant, I'm pleased 2.5 is on it's way soon. Some interesting
warnings from building the tarball:

cmsnamed.c: In function 'cmsDictDup':
cmsnamed.c:890:15: warning: variable 'new_dict' set but not used
[-Wunused-but-set-variable]
     _cmsDICT* new_dict;

I think you meant to do cmsDictAddEntry(new_dict), but given it's find
to cast down maybe new_dict should be removed altogether?

cmsopt.c: In function 'OptimizeByComputingLinearization':
cmsopt.c:939:26: warning: variable 'lIsLinear' set but not used
[-Wunused-but-set-variable]
     cmsBool lIsSuitable, lIsLinear;

Do we want to goto Error if the tonecurve is non-linear?

jpgicc.c:77:6: warning: 'OutOfMem' defined but not used [-Wunused-function]
 void OutOfMem(size_t size)

No idea here.

cmssm.c: In function 'ClosestLineToLine':
cmssm.c:221:22: warning: variable 'tc' set but not used
[-Wunused-but-set-variable]
     cmsFloat64Number tc, tN, tD;

I'm not sure of the math here, but it's quite a bit of work to get tc,
for it not to be used :)

Richard.

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Lcms-user mailing list
Lcms-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lcms-user

Reply via email to