On 8 Jul 2012, at 3:29, Alex Rønne Petersen wrote:
OK, first of all, this pull request should be merged:
https://github.com/ldc-developers/ldc/pull/137
Done.
Now, GitHub is really dodgy about this and doesn't let me send a pull
request to ldc-developers/druntime|phobos because my repos are forked
off the DPL ones. Even when I explicitly tell it to base on the
ldc-developers repos, it won't let me update the commit range.
Did you change the branch on the left side to "ldc" (we have no master
branch in the ldc-developers fork to prevent confusion)? The user
experience for that page indeed leaves a lot to be desired – we should
bug the GitHub guys about this.
So, please just pull these branches:
* https://github.com/alexrp/druntime/tree/ldc-master
* https://github.com/alexrp/phobos/tree/ldc-master
Merged most of the patches verbatim, removing the added .diff files from
the register popping patch [1].
I didn't merge the _d_newarrayOpT commit [2] though, because the code
would be broken on non-x86 afterwards anyway (ap2 is never set). After a
quick look at the code, I think right fix is to just take the X86 branch
for LCD all the time, although I'm not quite sure why ap2 is reset every
time in the loop on X86_64. Unfortunately, I can't look into verifying
that this is indeed the correct solution right now (i.e. that it works
on X86_64), but I didn't want to merge a patch which silently leaves
other platforms in a broken state.
Thanks again for your work,
David
[1]
https://github.com/alexrp/druntime/commit/6e61b4645ff3ad3f9b47988caa786be0892af9c9
[2]
https://github.com/alexrp/druntime/commit/717613ef2b42774fb2b40c360c80ad809d63c007
--
You received this message because you are subscribed to the Google Groups "LDC - the
LLVM D compiler" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/ldc-dev?hl=en.
