On 13.5.2016 9:23, Alexandru Ardelean wrote:
Coming back to the patches. Is it a problem with:
1) The UCI C changes ?
2) The dynamic log resize ?
3) The whole thing ?

Depending on what the problem is, we can adapt the patchset.
Or simply drop the whole thing if it's deemed un-needed by the community.

I don't like introducing uci capabilities to the low-level logd daemon. Intuitively it seems better to keep logd simple and separate from the file system.

The old approach of initscript and -S option might be adapted to the possible resizing need. The resize argument might be passed similarly from a command line option or as a parameter to an ubus call.

I think that the current default of 16 kB log buffer in RAM is too small for modern routers, especially if you have packages that produce some output to the bootlog. E.g. in my own router the default 16 kB is not enough to capture the whole boot process, so I have patched the logd initscript in my own build to default to a 64 kB buffer. Maybe the global default log buffer size could be increased?


_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to