On 26 May 2016 at 10:06, Mohammed Berdai <mohammed.ber...@gmail.com> wrote:
> On 05/26/2016 12:48 AM, Rafał Miłecki wrote:
>> E-mail topic is missing [PATCH] and should have a proper prefix
>> ("lantiq: ") and shouldn't have extra tags.
>> Also topic should say what your patch does, not what is the problem.
>>
>> On 26 May 2016 at 00:30, Mohammed Berdai <mohammed.ber...@gmail.com> wrote:
>>> Hi,
>>
>> We don't want "Hi"-s in a commit message :)
>>
>>
>>> This patch fixes the missing Lan interface config in the file
>>> /etc/config/network for ARV4518PWR01/A which results in eth0 and br-lan
>>> being down and therefore no way to access the router unless via UART-TTL.
>>
>> Line breaks to fit 80 chars per line would be nice.
>>
>>
>>> Med Berdai (medber)
>>
>> What is this? I don't think we want this in a commit message.
>>
>>
>>> Signed-off-by: Mohammed Berdai <mohammed.ber...@gmail.com>
>>> ---
>>> diff --git a/target/linux/lantiq/base-files/etc/board.d/02_network
>>> b/target/linux/lantiq/base-files/etc/board.d/02_network
>>> index b27b802..4166df0 100755
>>> --- a/target/linux/lantiq/base-files/etc/board.d/02_network
>>> +++ b/target/linux/lantiq/base-files/etc/board.d/02_network
>>> @@ -62,6 +62,10 @@ VG3503J)
>>> ucidef_set_interface_lan 'eth0'
>>> ;;
>>>
>>> +ARV4518PWR01*)
>>> + ucidef_set_interface_lan 'eth0'
>>> + ;;
>>> +
>>> DGN3500*)
>>> ucidef_add_switch "switch0" \
>>> "3:lan:1" "2:lan:2" "1:lan:3" "0:lan:4" "5t@eth0"
>
> Very clear. Thanks.
>
> Should I resend it with the corrections you highlighted or is it ok?
>
> Is it ok for me to ask in the ML that we should have a doc page for
> the proper way to write and send mails and patches?
>
> I myself had a bit of a challenge to setup vim write acceptable
> patches and my email client (Thunderbird) not mess with break-lines.
Please send V2. The easiest solution is to send patch using git tool.
1) Configure SMTP once and probably globally. For Gmail you can use:
git config --global sendemail.smtpserver smtp.gmail.com
git config --global sendemail.smtpserverport 587
git config --global sendemail.smtpencryption tls
git config --global sendemail.smtpuser usern...@gmail.com
2) You can send patch using:
git send-email --no-chain-reply-to \
--from "Name Surname <usern...@gmail.com>" \
--to lede-dev@lists.infradead.org \
0001-foo.patch
--
Rafał
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
