On 23/07/2016 23:02, p.wa...@gmx.at wrote: > Hi John, > >> please add macros for the register offsets in the header file and use >> them here. there should be 2 defines for the registers and one for the >> port offset. > > may I then also do this for the existing functions? > (I just copied code from get_port_link(), which also uses those > hard-coded magic constants) > > Best regards, > P. Wassi > > _______________________________________________ > Lede-dev mailing list > Lede-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/lede-dev >
yes please _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
