On Thu, Sep 8, 2016 at 8:14 AM, Felix Fietkau <[email protected]> wrote: > On 2016-09-08 16:47, Tim Harvey wrote: >> clean up usb gadget support: >> - rename gadget modules so that they appear under the usb-gadget sub-menu >> - change deps to auto-select >> >> Signed-off-by: Tim Harvey <[email protected]> >> --- >> v3: >> - update targets that use gadgets with new names >> >> v2: >> - leave libcomposite so opkg deps don't collide >> - do not rename modules to match kernel module names to avoid using _ char >> which is used to separate package name from version >> >> Signed-off-by: Tim Harvey <[email protected]> >> --- >> package/kernel/linux/modules/usb.mk | 34 >> +++++++++++++++--------------- >> target/linux/at91/Makefile | 2 +- >> target/linux/omap24xx/profiles/100-n810.mk | 2 +- >> 3 files changed, 19 insertions(+), 19 deletions(-) >> >> --- a/target/linux/omap24xx/profiles/100-n810.mk >> +++ b/target/linux/omap24xx/profiles/100-n810.mk >> @@ -16,7 +16,7 @@ define Profile/n810-base >> kmod-fs-vfat kmod-fs-msdos \ >> kmod-input-evdev \ >> kmod-leds-gpio \ >> - kmod-usb-tahvo kmod-usb-eth-gadget \ >> + kmod-usb-tahvo kmod-usb-gadget-eth \ > This is still broken, because kmod-usb-eth-gadget now depends on > kmod-usb-gadget instead of selecting it. > Maybe it would be a good idea to leave the dependencies alone and just > mark kmod-usb-gadget and kmod-usb-lib-composite as hidden. >
I could add kmod-usb-lib-composite and kmod-usb-gadget to the two targets that default them, but yes I think a better option is to forget about the submenu and make those as hidden as I see no value in users selecting them without a gadget driver that uses them. Tim _______________________________________________ Lede-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/lede-dev
