On 17/10/2016 17:37, Alberto Bursi wrote:
> 
> 
> On 10/17/2016 04:31 PM, John Crispin wrote:
>>> I'm going to add xfs support to other fstools components in a following
>>> patch.
>>
>> please explain what this would consist of. i was about to merge your
>> patch but your comments make me think it is incomplete.
>>
> 
> Sorry for the confusion.
> 
> This patch allows block-mount to mount xfs and f2fs on boot, I tested 
> the patch and it works on my tp-link test router.
> 
> But afterwards I searched for similar checks for code in the same 
> package/source folder, and yes, in fstools there are more 
> filesystem-specific checks and operations.
> Code for f2fs is already there, but code for xfs is not.
> 
> I didn't yet have the time to look more closely what that does exactly.
> 
> A list of files that must be changed to add xfs:
> 
> /mount_root.c there are filesystem type checks
> 
> /libfstools/find.c line 88 there is a filesystem type check.
> 
> /libfstools/libfstools.h line 25 there is a list of filesystem-specific 
> variables
> 
> /libfstools/overlay.c line 198, another filesystem type check
> 
> /libfstools/rootdisk.c line 264, there is code to automatically format 
> the overlay as either f2fs or ext4 if it isn't formatted correctly.
> 
> So while with my patch block mount will work with both f2fs and xfs, 
> some other operations I didn't know about are not going to work on xfs.

ok, please resend the whole patch once xfs support has been properly
added to fstools. this current "some works some may not" sounds quirky.
lets just drop the patch until; you had time to fully verify and add the
missing pieces.

thanks for the explaination.

        John

_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to