Rafał Miłecki <zaj...@gmail.com> wrote: > On 20 October 2016 at 08:11, Chris Blake > <chrisrblak...@gmail.com> wrote: > > I agree that would work in terms of functionality, but the issue with > > that logic is if you hold the button over 5 seconds, the system LED > > will start flashing (as expected) but then no action is taken on the > > board. The reason for my logic change was just to ensure the board > > would reboot in that case. > > That would just as confusing for the user. If jffs2reset is > unsupported on a device, make sure we also don't start > blinking. > > It will be more clear that way: user keeps RESET pressed for 5+ > seconds, LED doesn't start blinking, device doesn't reboot. It > somehow indicated factory reset wasn't started.
Should this actually be fixed by having the button handler just call "firstboot" (and fixing it there if necessary) rather than explicitly within the button handler? Sincerely, Karl P
signature.asc
Description: OpenPGP Digital Signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
