Hi Stijn, > Running the script to update to 4.4.32 on top of the patch above, and > already have more changed files, so NAK here as well.
I'm still on this topic, still willing to learn and improve and still not discouraged too much. To see where things have gone wrong on my side (which I guess was the reason for patch rejection), I've just compared your 4.4.32 to my 4.4.32 refreshing. In total we have four (minor) differences here: include/kernel-version.mk: for the checksum you used md5 (as the name suggests), while I have sha256 as someone has started it like this, and I've just followed it like a sheep. apm821xx/patches-4.4/804-usb-dwc2-add-amcc-usb-otg-405ex.patch: Here, you add more context around the actual patch, which I completely missed since it applies fine. ar71xx/patches-4.4/910-unaligned_access_hacks.patch Half of the patch is removed, since alreay included upstream. I additionally refreshed the diffstat for that patch and not only deleted the relevant line here. lantiq/patches-4.4/0154-lantiq-pci-bar11mask-fix.patch Again, you add more context around the actual patch, which I did not do, since it applies fine. Besides these things, our diffs are completely the same. So I'm trying to understand what is wrong about my attempt. I've re-read the https://wiki.openwrt.org/doc/devel/patches According to the wiki, the quilt-config is just for a preferred format for patches. It's not mandatory. Furthermore it says that for refreshing, the refresh make target can be used. (Leaving the interpretation that there are also other ways). However, if there's only this one and only true and correct way for this task, this can be clearly stated in the wiki, or even here in the mailinglist. Don't get me wrong, I'm still trying to see if I can improve here, or better put my time into other topics. At the moment I don't see a way I could really do different here (besides using the exact same configuration), so maybe I should look into something different then... Best regards, P. Wassi _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev