The defines were totally correct, what's wrong are the registers in the interrupt function from bcm-phy-lib. I just replaced the defines just to reflect the similiarities with the "Broadcom PHY driver" from where the interrupt function was taken. It eventually could facilitate the work if a further integration is done.
2016-12-18 3:50 GMT+01:00 Florian Fainelli <[email protected]>: > Le 12/17/16 à 17:19, Daniel Gonzalez Cabanelas a écrit : >> The internal phy is using wrong registers for the config interrupt function, >> causing incorrect behavior when detecting the link activity. Fix it. >> >> We cannot use the bcm_phy_config_intr function from the bcm-phy-lib.c >> because it uses different registers from brcm63xx. We need to use >> our own function, which matches with the one used by the >> "Broadcom PHY driver" (brcm_fet_config_intr at broadcom.c). >> >> brcm63xx internal phy uses the same registers as the ones defined in >> brcmphy.h for fast ethernet, use them instead. > > Humm how did you find out? Not saying this is wrong, but since these > defines were added to the driver, it sounds like they would have been > correct. > -- > Florian _______________________________________________ Lede-dev mailing list [email protected] http://lists.infradead.org/mailman/listinfo/lede-dev
