2017-03-01 19:46 GMT+01:00 Florian Fainelli <f.faine...@gmail.com>: > On 03/01/2017 10:37 AM, Daniel Gonzalez Cabanelas wrote: >> Add support for the Comtrend AR-5315u router >> >> This a BCM6318 based board, 64 MB RAM, 16 MB SPI flash, >> with an onboard BCM43217 wifi, 4 ethernet ports and 1 >> USB host port >> >> Signed-off-by: Daniel Gonzalez Cabanelas <dgcb...@gmail.com> > > There is something wrong with your patches submitted, in that they don't > conform to this: > > subject: something > > Commit message > > Signed-off-by: myself > --- > <git diff> > > Essentially, we are missing the --- between your Signed-off-by tag and > the git diff, how are you producing these patches?
Hi Florian. For the patches I use this procedure git add file1 file2 git diff --cached > mypatch.patch Then I copy the patch into my email client (KMail) and send it as a regular mail to the mailing list > Can you make sure you > use git format-patch + git send-email and do a git commit -s when > creating local changesets? I guess this generates the patch with the required header? git add file1 file2 git commit -s git format-patch -1 HEAD only the stuff between --- and signed-off is missing, or is there anything else wrong?. Just to be sure because I also want to continue using KMail for sending patches. _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev