Hi Rafal,
On Sun, May 21, 2017 at 05:02:44PM +0200, Rafał Miłecki wrote:
> Hi,
>
> I noticed commit 0dcc36fc7ddec ("kernel: add hwmon for W83627EHF and
> family") in the LEDE tree that doesn't look OK to me.
>
> 1) Package for hwmon-w83627ehf
> Do we need it to be a package? Or could it be built-in into the kernel?
> Do we need it to be a global package? Usually hwmon drivers are
> designed for a specific device and it should be enough to have it in
> target/linux/*/modules.mk
True, but all other x86-specific hwmon modules are in
package/kernel/linux/modules as well and I'd rather wanted it to be
consistent.
>
> 2) 800-hwmon-w83627ehf-dont-claim-nct677x.patch
> I really don't like this one as it's totally unclear why we need this
> change. What's wrong with NCT6775 and the w83627ehf driver? It should
> be well described in the patch.
Sorry for the lack of a more detailed description.
The problem here is that the W83627EHF driver also claims the NCT677x
hardware but doesn't support all features (according to
Philip Prindeville). I reckon he can provide more information regarding
which features which are available when using the nct6776 driver are
missing in the w83627ehf driver on NCT677x hardware.
Cheers
Daniel
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
