Hello Hauke,
AFAIK, "{image,kernel,rootfs} is too big" errors are/were just ignored
before. As I understand this, with such approach, we can keep support
for device and allow users to build images with custom configuration
(different kernel options, set of packages, etc.) which makes image
generation possible. If you look closer at the yesterday buildbot log
[1], this was true for (some of) below devices (grep for "WARNING.*too
big").
What I don't really understand here is why disabling image generation
only for below boards made buildbot happy again if there are many other
which have similar issues now [2] and are just ignored. How below boards
were selected and why image for, for example "re450", wasn't disabled if
it also fails?
Also, please have a look at my comments inline, below.
[1]
http://phase1.builds.lede-project.org/builders/ar71xx%2Fgeneric/builds/388/steps/images/logs/stdio
[2]
http://phase1.builds.lede-project.org/builders/ar71xx%2Fgeneric/builds/389/steps/images/logs/stdio
On 22.10.2017 23:19, LEDE Commits wrote:
hauke pushed a commit to source.git, branch master:
https://git.lede-project.org/f7a6fd31539be54d14d7c52b491b40b26bf8f740
commit f7a6fd31539be54d14d7c52b491b40b26bf8f740
Author: Hauke Mehrtens <ha...@hauke-m.de>
AuthorDate: Sun Oct 22 23:10:08 2017 +0200
ar71xx: deactivate some boards with too small kernel partitions
This affects the following boards:
* dr344
The only way to fix this one I can think about, is to change mtd order
(use kernel/rootfs instead of rootfs/kernel). But this would break
backward compatibility and require change of "bootcmd" variable in
U-Boot environment _before_ upgrade to new image.
* archer-c58-v1
* archer-c60-v1
* tl-wr902ac-v1
* tl-wr942n-v1
These should be easily fixable. They use TP-Link "safeloader" image type
with kernel/rootfs order (os-image/file-system), so we can increase
kernel partition size and reduce the rootfs.
* ubnt-uap-pro
* ubnt-unifi-outdoor-plus
No idea about these two.
--
Cheers,
Piotr
The build fails for any of these boards because the resulting kernel
image will not fit into the kernel partition.
When CONFIG_KERNEL_KALLSYMS is not set it could be that the kernel will
fit onto the board again, this is the case for release images.
Signed-off-by: Hauke Mehrtens <ha...@hauke-m.de>
---
target/linux/ar71xx/image/generic.mk | 1 -
target/linux/ar71xx/image/tp-link.mk | 5 ++---
target/linux/ar71xx/image/ubnt.mk | 1 -
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/target/linux/ar71xx/image/generic.mk
b/target/linux/ar71xx/image/generic.mk
index 6f5a701..3c5fcc3 100644
--- a/target/linux/ar71xx/image/generic.mk
+++ b/target/linux/ar71xx/image/generic.mk
@@ -358,7 +358,6 @@ define Device/dr344
MTDPARTS :=
spi0.0:256k(u-boot)ro,64k(u-boot-env)ro,6336k(rootfs),1408k(kernel),64k(nvram),64k(art)ro,7744k@0x50000(firmware)
IMAGE/sysupgrade.bin := append-rootfs | pad-rootfs | pad-to
$$$$(ROOTFS_SIZE) | append-kernel | check-size $$$$(IMAGE_SIZE)
endef
-TARGET_DEVICES += dr344
define Device/dr531
DEVICE_TITLE := Wallys DR531
diff --git a/target/linux/ar71xx/image/tp-link.mk
b/target/linux/ar71xx/image/tp-link.mk
index ae711e7..868bbda 100644
--- a/target/linux/ar71xx/image/tp-link.mk
+++ b/target/linux/ar71xx/image/tp-link.mk
@@ -150,7 +150,7 @@ define Device/archer-c60-v1
MTDPARTS :=
spi0.0:64k(u-boot)ro,64k(mac)ro,1344k(kernel),6592k(rootfs),64k(tplink)ro,64k(art)ro,7936k@0x20000(firmware)
SUPPORTED_DEVICES := archer-c60-v1
endef
-TARGET_DEVICES += archer-c25-v1 archer-c58-v1 archer-c59-v1 archer-c60-v1
+TARGET_DEVICES += archer-c25-v1 archer-c59-v1
define Device/archer-c5-v1
$(Device/tplink-16mlzma)
@@ -1043,7 +1043,6 @@ define Device/tl-wr902ac-v1
append-metadata | check-size $$$$(IMAGE_SIZE)
MTDPARTS := spi0.0:128k(u-boot)ro,7360k(firmware),640k(tplink)ro,64k(art)ro
endef
-TARGET_DEVICES += tl-wr902ac-v1
define Device/tl-wr940n-v4
$(Device/tplink-4mlzma)
@@ -1118,4 +1117,4 @@ define Device/tl-wr942n-v1
MTDPARTS :=
spi0.0:128k(u-boot)ro,1344k(kernel),13120k(rootfs),64k(product-info)ro,64k(partition-table)ro,256k(oem-config)ro,1344k(oem-vars)ro,64k(ART)ro,14464k@0x20000(firmware)
SUPPORTED_DEVICES := tl-wr942n-v1
endef
-TARGET_DEVICES += tl-wr940n-v4 tl-wr941nd-v2 tl-wr941nd-v3 tl-wr941nd-v4
tl-wr941nd-v5 tl-wr941nd-v6 tl-wr941nd-v6-cn tl-wr942n-v1
+TARGET_DEVICES += tl-wr940n-v4 tl-wr941nd-v2 tl-wr941nd-v3 tl-wr941nd-v4
tl-wr941nd-v5 tl-wr941nd-v6 tl-wr941nd-v6-cn
diff --git a/target/linux/ar71xx/image/ubnt.mk
b/target/linux/ar71xx/image/ubnt.mk
index f80f2f1..dfc795b 100644
--- a/target/linux/ar71xx/image/ubnt.mk
+++ b/target/linux/ar71xx/image/ubnt.mk
@@ -256,4 +256,3 @@ define Device/ubnt-unifi-outdoor-plus
BOARDNAME := UBNT-UOP
DEVICE_PROFILE := UBNT
endef
-TARGET_DEVICES += ubnt-uap-pro ubnt-unifi-outdoor-plus
_______________________________________________
lede-commits mailing list
lede-comm...@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-commits
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
