Citeren Arjen de Korte <arjen+l...@de-korte.org>:
Citeren Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk>:
On 17 Dec 2017, at 17:22, Etienne Haarsma <bladeoner...@gmail.com> wrote:
uint8_t *oob = ops->oobbuf;
uint8_t *buf = ops->datbuf;
-@@ -2662,7 +2697,7 @@ err_out:
- static int panic_nand_write(struct mtd_info *mtd, loff_t to, size_t len,
- size_t *retlen, const uint8_t *buf)
- {
-- struct nand_chip *chip = mtd->priv;
-+ struct nand_chip *chip = mtd_to_nand(mtd);
- struct mtd_oob_ops ops;
- int ret;
-
I’m unconvinced this is the correct thing to do - in essence just
dropping that bit of the patch. Will panic to nand still work?
It should. The above patch is *required* in kernel-4.6 and above.
The mtd_to_nand() helper function was added in
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/patch/include/linux/mtd/nand.h?id=c291b3c3527fa962f53862426e0e4258d7bd8269
and subsequently changed to
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/patch/include/linux/mtd/nand.h?id=2d3b77bac34bf99d7fdfd712ec2dc4317b3e850b
But the mtd_to_nand() helper function never made it in kernel-4.4 as
far as I can see, so I would be really surprised if kernel-4.4.106
would even compile with this patch applied.
Aaaand, never mind the nonsense above. This helper function was added
in the same patch...
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
