On Fri, Feb 2, 2018 at 4:54 AM, Karl Palsson <ka...@tweak.net.au> wrote: > > Rosen Penev <ros...@gmail.com> wrote: >> -Wsign-compare was breaking my builds when i disabled MIPS16 on >> ramips (mt7621). Since this will probably not get fixed, >> disable it. > > Given the fine tuned nature of all your prior commits, why are > you now all of a sudden avoiding actually fixing the bad sign > comparisons?
It breaks my build. Previous efforts at fixing have been unsuccessful. > Turning them off wholesale sounds like a terrible > idea! -Wsign-compare is part of -Wextra, which is not enabled by default for a lot of OpenWrt projects. There is at least one such project that disabled this warning specifically. I don't think anyone cares. > > Cheers, > Karl P > > >> >> Signed-off-by: Rosen Penev <ros...@gmail.com> >> --- >> CMakeLists.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/CMakeLists.txt b/CMakeLists.txt >> index 57804cf..0449a59 100644 >> --- a/CMakeLists.txt >> +++ b/CMakeLists.txt >> @@ -3,7 +3,7 @@ INCLUDE(CheckLibraryExists) >> INCLUDE(CheckFunctionExists) >> >> PROJECT(ubox C) >> -ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -g3 >> -Wmissing-declarations) +ADD_DEFINITIONS(-Os -Wall -Werror >> --std=gnu99 -g3 -Wmissing-declarations -Wno-sign-compare) >> >> OPTION(BUILD_LUA "build Lua plugin" ON) >> OPTION(BUILD_EXAMPLES "build examples" ON) >> -- >> 2.7.4 >> >> >> _______________________________________________ >> Lede-dev mailing list >> Ledeemail@example.com >> http://lists.infradead.org/mailman/listinfo/lede-dev _______________________________________________ Lede-dev mailing list Ledefirstname.lastname@example.org http://lists.infradead.org/mailman/listinfo/lede-dev