On 03-05-18 14:01, Felix Fietkau wrote:
On 2018-05-03 13:12, Felix Fietkau wrote:
On 2018-05-02 17:37, Koen Vandeputte wrote:
Config moved from option.h to localoptions.h
refreshed all patches
deleted upstreamed patches:
- 010-runtime-maxauthtries.patch
- 610-skip-default-keys-in-custom-runs.patch
introduced new patch:
- 610-disable-ec-by-default.patch
This patch adds the EC definitions which are altered by the Makefile when
(de)selecting EC options.
Tested on both LE (arm) and BE (mips) architectures.
Tested with all dropbear menuoptions on/off
Binary sizes in bytes:
2017.75
-------
Openwrt default : 172405
Openwrt default IPK : 86512
Openwrt default + ECC + zlib: 197301
Openwrt default IPK + ECC + zlib: 98709
2018.76
-------
Openwrt default : 277260
Openwrt default IPK : 130534
Openwrt default + ECC + zlib: 322928
Openwrt default IPK + ECC + zlib: 149187
Signed-off-by: Koen Vandeputte <koen.vandepu...@ncentric.com>
---
V2:
--> Added binary sizes
--> Disabled 2 more options (DROPBEAR_USE_PASSWORD_ENV & DROPBEAR_SFTPSERVER)
Skipped adding the sftp server as a menuconfig option, as it's not integrated
into dropbear itself
Binary size seems to have exploded compared to the previous version.
Checking all configfile options and the buildoptions for Configure, I cannot
pinpoint the rootcause for this massive increase.
The libtom's seem to be build using Os.
I tried your patch and the warnings during build indicate that the build
system CFLAGS are not passed correctly.
If you fix that, the size might go down again...
The change from https://github.com/openwrt/openwrt/pull/915 does not
have the same issue with passing build system CFLAGS. With the commits
from that pull request + an extra build flag (see my last comment), the
size of the updated package is very close to the one from the old version.
- Felix
Hi Felix,
Thanks for testing.
If you feel the Pull Request is in a better shape, feel free to drop
this patch.
I really don't mind who does the actual upgrade :)
Thanks,
Koen
_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev
