full patch is actually :
$ diff -u ~/dev/ledger/lisp/ledger.el ~/.emacs.d/site-lisp/ledger.el
--- /home/thierry/dev/ledger/lisp/ledger.el 2012-03-16
23:36:22.000000000 +0100
+++ /home/thierry/.emacs.d/site-lisp/ledger.el 2012-07-17
00:26:49.490970738 +0200
@@ -494,7 +494,7 @@
(account ledger-acct)
(inhibit-read-only t)
cleared)
- (when (or (equal (car where) "<stdin>") (equal (car where)
"/dev/stdin"))
+ (when (markerp (cdr where))
(with-current-buffer ledger-buf
(goto-char (cdr where))
(setq cleared (ledger-toggle-current 'pending)))
@@ -533,7 +533,7 @@
(defun ledger-reconcile-delete ()
(interactive)
(let ((where (get-text-property (point) 'where)))
- (when (or (equal (car where) "<stdin>") (equal (car where)
"/dev/stdin"))
+ (when (markerp (cdr where))
(with-current-buffer ledger-buf
(goto-char (cdr where))
(ledger-delete-current-entry))
@@ -568,8 +568,7 @@
(let ((where (get-text-property (point) 'where))
(face (get-text-property (point) 'face)))
(if (and (eq face 'bold)
- (or (equal (car where) "<stdin>")
- (equal (car where) "/dev/stdin")))
+ (markerp (cdr where)))
(with-current-buffer ledger-buf
(goto-char (cdr where))
(ledger-toggle-current 'cleared))))
On Monday, July 16, 2012 11:13:45 PM UTC+2, thierry wrote:
>
>
>
> On Monday, March 19, 2012 2:00:54 AM UTC+1, [email protected] wrote:
>>
>> Hi, all --
>>
>> I'm running the latest next version (or at least it's close -- I upgraded
>> earlier today). The reconcile function in ledger.el no longer works. When
>> I call the reconcile function, the program loads the list of unreconciled
>> transactions for the account as expected. However, pressing the space bar
>> merely advances the cursor to the next line. The transaction is not marked
>> in any way, and it is not bolded. I've verified that the space bar is
>> bound to ledger-reconcile-toggle; calling that function directly has the
>> same effect -- it merely moves the cursor to the next line.
>>
>> Other editing keys work as expected in the reconcile buffer.
>>
>> I've looked through the code defining ledger-reconcile-toggle, but nothing
>> problematic jumps out to my untrained eye.
>>
>> I'm not sure when this broke. I know it worked a month ago when I was
>> reconciling accounts.
>>
>> The problem could well be related to the fact that I'm still using the
>> ledger.el for version 2.6 or so. I've not been able to make the newer one
>> work. Unless I've missed something (entirely possible), the code defining
>> ledger-reconcile-toggle in ldg-new.el (for 3.0) is the same as that in the
>> older ledger.el.
>>
>> I'd appreciate any help anyone can offer -- or even the assurance that
>> it's working as expected (or not) for others.
>>
>> Thanks.
>> --
>> John Rakestraw
>>
> I am on Linux Mint Debian Edition current version, Ledger 3.0.0-20120518
> from git repo next branch, and GNU Emacs 23.3.1
> I have same issue with ledger.el, where ledger-reconcile works, but
> ledger-reconcile-toggle does not with the same symptoms, that is no toggle.
> I searched for a while, and found a solution, but I do not know why it
> works, I just found it with test/try/logic, here is patch
>
> $ diff -u ~/dev/ledger/lisp/ledger.el ~/.emacs.d/site-lisp/ledger.el
> --- /home/thierry/dev/ledger/lisp/ledger.el 2012-03-16
> 23:36:22.000000000 +0100
> +++ /home/thierry/.emacs.d/site-lisp/ledger.el 2012-07-16
> 22:18:46.528814351 +0200
> @@ -494,7 +494,7 @@
> (account ledger-acct)
> (inhibit-read-only t)
> cleared)
> - (when (or (equal (car where) "<stdin>") (equal (car where)
> "/dev/stdin"))
> + (when (markerp (cdr where))
> (with-current-buffer ledger-buf
> (goto-char (cdr where))
> (setq cleared (ledger-toggle-current 'pending)))
>
>
> If i try to use ldg-new.el, the ledger-reconcile lisp function does not
> work. I suspect that this is because ledger-do-reconcile is defun'ed, but
> empty.
>
> Thierry
>
