Martin, John, I have read again 712 and 713 bugs descriptions. I then tested branch 713-costs. I had to "git cherry-pick 8b3f8d1", but this is anecdote.
There is no difference for me between HEAD and branch 713-costs on *my* data. I have some scripts to do graphics on my ledger data, those scripts are using --basis (= -B) option, and I do not have any regression, nor difference in results. I just wonder what is now the difference between --price (=-I) and --basis (=-B, --cost) ? I personally do not use --price option, so I would argue that this patch is correcting bug #712 and #713, and that I vote for merging it in master branch. Thanks Thierry On Thursday, May 15, 2014 12:15:34 AM UTC+2, Martin Michlmayr wrote: > > John and I had a long discussion on IRC a few days ago which resulted > in a patch that changes the definition of cost in ledger (-B). > > The background of the discussion was bugs #712 and #713. > > Bug #712 is about Equity:Capital Gains and Equity:Capital Loss > entries ledger automatically generates that are in my opinion > incorrect. (<http://bugs.ledger-cli.org/show_bug.cgi?id=712>) > > Bug #713 is about strange behaviour with -B after a capital gain or > loss is made (<http://bugs.ledger-cli.org/show_bug.cgi?id=713>). > > As it turns out, both of these issues can be addressed by changing the > definition of cost in ledger. In the past, if you bought 1 AAA for > $10 and then sold it for $12, ledger would take $12 as the cost. With > the patch, the cost is $10. In my opinion, this brings ledger in line > with accounting expectations. > > I've done extensive tests on my own ledger files, but John and I would > like to ask for more people to test the patch before it's applied > (especialy people who made capital gains or losses). You can find the > patch on the 713-costs branch. Please test that branch and let me > know if you see any strange behaviour. > > I've attached two files from John that show how ledger sees some > transactions (for the old and new behaviour). > > -- > Martin Michlmayr > http://www.cyrius.com/ > -- --- You received this message because you are subscribed to the Google Groups "Ledger" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
