Just looking at commit 3144:
if(-d "$tempdir"){}
else
{
my $rc=system("mkdir -p $tempdir");#TODO what if error?
seems to me, if we have an error creating a tempdir, we have a larger
problem, i.e., the filesystem where we want to create the tempdir is
mounted read-only or we don't have write permissions (which should
never happen in /tmp).
how about something like:
(-d $tempdir){ (-w $tempdir) || die "$tempdir not writable"; } ||
system("mkdir -p $tempdir") || die "cannot create $tempdir";
my $.02,
David A. Bandel
--
Two things are infinite: the universe and human stupidity; and I'm not
sure about the the universe. -- Albert Einstein
Visit my web page at: http://david.bandel.us/
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Ledger-smb-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel
