Hi, I am ready to start fixing the P::C::P::ValuesAndExpressions::ProhibitMagicNumbers criticisms.
I propose a LedgerSMB::Magic to hold the constants. We could be using a http code table from CERT or whomever, but we seem to be using only 10 or so such codes. So I suggest we not bother at this time; once we've consolidated our magic such reworking will be pretty easy. I propose using the constant pragma as that is already being used; but would be happy to move to 'Readonly' if the greater convenience is wanted. Be well, Rob ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Ledger-smb-devel mailing list Ledger-smb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ledger-smb-devel