Latest response from Samsung + my reply. Also the same violation is found in another lib (libMali.so)
-bugficks ----------------------------------------------------------------------------------- Hello, I know I can build libSDAL.so with files from libSDAL.zip, that is not the issue. The issue is that you can't simply copy functions, etc from FFmpeg into your own files and then say it's LGPL. FFmpeg has a checklist what you are allowed to do and what not (most notably use FFmpeg as whole and dynamic linking). Since you fail about every point in that checklist you are required to release full source code for both libSDAL and libMali. Thanks for looking into libMali.so issue. Kind Regards, -bugficks On 8/29/2014 1:11 PM, Opensource Request wrote:> [SAMSUNG OSRC COMMENTS DELIVERY NOTIFICATION] > > Dear bugficks, > > Thank you for your interest in our product. > For < libSDAL.so > request, we have done our internal review with > developer and license members. > This was an oversight and we do apologize for this error. > The only source code affected that was re-used from ffmpeg is tsmuxenc.c > and tsmuxenc.h. > As like our previous mail, the affected source code, other needed object > files and build script made available from: > http://opensource.samsung.com/ -> TV&VIDEO -> libSDAL.zip > You can make the whole libSDAL.so without any difficulties. > Other model's attected code that was re-used from ffmpeg will be > uploaded in a few days. > > And < libMALI.so >, we are currently reviewing internally. > We can reply for our inspection result within next week. > Thank you for your patience in advance. > > Kindly regards, > Samsung Visual Display Division's Opensource team. > On 8/26/2014 4:14 PM, Bug Ficks wrote: > Today Samsung re-uploaded libSDAL.zip. Archive now contains LGPL-2.1.txt > and they've added proper license headers to tsmuxenc.h/.c. > > It's still not a full source release though. > > For completeness I've added my last mail and their response below. > > -bugficks > > > ----------------------------------------------------------------------------------- > On 8/25/2014 9:21 AM, Opensource Request wrote: > > Dear Bug Ficks, > > Thank you for your advices. > Unfortunately we have missed LGPL v2.1 license notice on 2 files' > heading with our fault. > We will correct and re-upload as soon as possible. > Sorry for this fault. > > For other question, we have delivered to developers of your mail. > When their reply is arrives, we will let you know in shout time. > > Thank you at all time. > Kindly regards, > Samsung Visual Display Division's Opensource team. > > ----------------------------------------------------------------------------------- > Date : 2014-08-24 23:11:59 (GMT+09:00) > > Subject:Re: [Notification from Samsung Open Source Release Center] > > Hello, > > I finally got feedback from gpl-violations.org. > > I'm sorry to inform you that your libSDAL release is not sufficient. > Samsung is required to release full source code for libSDAL. > > You fail LGPL requirements for FFmpeg in about every point listed here: > https://www.ffmpeg.org/legal.html > > -no dynamic linking > -not using lib FFmpeg but only copied some functions/structures. > -you even removed FFmpeg license from tsmuxenc.h/.c > > Hence to conform with LGPL Samsung has to release complete source code. > > > Kind Regards, > -bugficks > > ----------------------------------------------------------------------------------- > > > > On 8/25/2014 12:11 PM, Ralph Corderoy wrote: >> Hi bugficks, >> >>> In that zip are tsmuxenc.c and tsmuxenc.h which are based on >>> https://www.ffmpeg.org/doxygen/trunk/mpegtsenc_8c.html >> >> Thanks for the precise detail. >> >>> If you're interested I'll keep you posted. >> >> Yes, please keep the list succinctly posted; its archive is a useful >> public resource for future Googlers. >> >> Cheers, Ralph. >> >> > > > >
