>
> Then I think we should remove SSE code for unaligned memory and state in
> the documentation that SSE is only available for aligned memory.
Ok.
> I will await your changes on github before I merge the new SSE code to
> sourceforge master.
I have completed re-doing my changes.
I had to use rebase, so i put them to the new branch: dedup
<https://github.com/LebedevRI/lensfun/tree/dedup>
I am unable to test everything [manually], but from what i tested, nothing
seems to be broken.
I added basic warning about 16-bit alignment to the Doxygen, but that could
probably be extended.
There is still the issue that my new SSE code for lf_f32 produces different
results from the plain code,
but i think that can be resolved once "testsuite" is in place?
On Sat, Oct 11, 2014 at 12:53 PM, Sebastian Kraft <[email protected]>
wrote:
> > All of the assumptions looks sane to me.
> >
> > It is basically the question of code quality vs. some speed increase for
> > using SSE code for unaligned buffers for some amount of users.
> > If we decide that former is more important, :
> >
> > - No code duplication.
> > - No *C++11 Lambdas* are needed to avoid code duplication.
> > - We can also get rid of *_Select_* helper functions.
> > - Probably no bump to C++11, not sure.
> >[...]
> > So yes, *i* believe we can simplify it by removing wrappers around SSE
> for
> > unaligned buffers,
> > adding checking for proper alignment and falling back to non SSE code.
> >
> > However final decision is yours to make.
> > I will change my (and all other LF code, if needed) in the needed way,
> > depending on the final decision.
> >
>
> Then I think we should remove SSE code for unaligned memory and state in
> the documentation that SSE is only available for aligned memory. I will
> await your changes on github before I merge the new SSE code to
> sourceforge master.
>
> Sebastian
>
>
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
_______________________________________________
Lensfun-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lensfun-users
